Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change performance diagnostics to use Managed Identity #3509

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change performance diagnostics to use Managed Identity #3509

wants to merge 2 commits into from

Conversation

lukeluong1212
Copy link
Collaborator

@lukeluong1212 lukeluong1212 commented Nov 12, 2024 •
edited
Loading

Add MSI support for performance diagnostics and remove SAS usage per Security Wave requirements.

Notes:

  • This will still not work until the MSI support for Azure Performance Diagnostics is released. The work for that is still on-going.
  • The VM will need to be preconfigured with these role assignments for Storage Account at Subscription level so it can inherit the permissions:
    - Storage Account Contributor
    - Storage Account Blob Contributor
    - Storage Account Table Contributor

@LiliDeng
Copy link
Collaborator

@lukeluong1212 please change the test priority back to 1 in

lisa/microsoft/testsuites/vm_extensions/azureperformancediagnostics.py

Line 63 in 08b810d

priority=5,

@LiliDeng
Copy link
Collaborator

@lukeluong1212 let know which package version need to be updated, thanks!

@lukeluong1212
Copy link
Collaborator Author

@lukeluong1212 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squirrelsc squirrelsc Awaiting requested review from squirrelsc squirrelsc is a code owner

@LiliDeng LiliDeng Awaiting requested review from LiliDeng LiliDeng is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeluong1212 @LiliDeng